Add Playback Recording Feature #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the Playback Recording Feature by introducing a new file that implements playback of recorded simulation actions using HDF5 files, and resetting the simulation environment accordingly. Key changes include:
- Adding a new script (playback_recorded.py) to handle playback of recorded episodes.
- Integrating argument parsing and configuration loading for simulation tasks.
- Implementing functions to retrieve episode data and reset both the robot and target state in the simulation.
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Nic-Ma
approved these changes
May 7, 2025
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Could you please help change the hardcode "cuda:0" to be a device parameter?
Others look good to me.
Thanks.
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/replay_recording.py
Show resolved
Hide resolved
9 tasks
Nic-Ma
reviewed
May 8, 2025
Nic-Ma
approved these changes
May 8, 2025
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Contributor
|
/build |
Contributor
|
/build |
mingxin-zheng
approved these changes
May 13, 2025
Contributor
mingxin-zheng
left a comment
mingxin-zheng
left a comment
There was a problem hiding this comment.
Thanks for adding the features and tests.
Will merge this once we settle down if 0.1.1 tagging is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #127
Add Playback Recording Feature